Fix cargo-gpu in build script failing when called by Miri or Clippy #335
+166
−32
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tuguzT
changed the title
Firestar99
changed the title
Firestar99
changed the title
tuguzT
requested review from
eddyb,
LegNeato,
Firestar99 and
schell
as code owners
|
Please look at Rust-GPU/cargo-gpu#101 for additional context |
LegNeato
requested changes
Jul 19, 2025
| // overwritten by spirv-builder anyway | ||
| cargo.env_remove("CARGO_ENCODED_RUSTFLAGS"); | ||
|
|
||
| cargo |
There was a problem hiding this comment.
These seem to be added with no comment, and RUSTC_WRAPPER is both here and above.
There was a problem hiding this comment.
I've just removed duplicates from removed env vars and tried to add relevant comments
There was a problem hiding this comment.
oh my bad, thanks for fixing it
LegNeato
approved these changes
Jul 22, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cargo-gpu Rust-GPU/cargo-gpu#101
@Firestar99: I've added a new
CargoCmdstruct that should handle all env vars in one central place for both spirv-builder and cargo-gpu install. In case of a failure, it alsodebug!logs the env vars which were removed and which were inherited with their values, to make debugging these sort of issues easier in the future.As stated in Rust-GPU/cargo-gpu#93, build script which uses
rustc_codegen_spirvviacargo-gpufailed to build shader crate while using Miri.This pull request fixes this issue by removing
RUSTC_WRAPPERenvironment variable fromcargocall.